Alissa Bonas has posted comments on this change. Change subject: restapi: add template versions support ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/23453/13/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java: Line 386: model.setTunnelMigration(entity.getTunnelMigration()); Line 387: model.setMigrationDowntime(mapNullToMinusOne(entity.getMigrationDowntime())); Line 388: // if a base template id exists, that means this is a template version Line 389: // so need to populate template version properties Line 390: if (entity.getBaseTemplateId() != null && !entity.getBaseTemplateId().equals(entity.getId())) { > i think you can use: if (!entity.isBaseTemplate()) Done Line 391: TemplateVersion version = new TemplateVersion(); Line 392: version.setVersionName(entity.getTemplateVersionName()); Line 393: version.setVersionNumber(entity.getTemplateVersionNumber()); Line 394: Template baseTemplate = new Template(); -- To view, visit http://gerrit.ovirt.org/23453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8e4c498c4a1856ac341237837db40db8375c6da Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
