Martin Sivák has posted comments on this change. Change subject: backend, db: store additional hosted engine info ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23530/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java: Line 28: // Score 0 means no HA agents are on this host Line 29: // Positive score means there is an agent Line 30: private Integer highlyAvailableScore; Line 31: private int anonymousHugePages; Line 32: private Boolean highlyAvailableIsConfigured; I would prefer more verbose documentation. Expected value is obvious here, but info about who provides the value and when it is used would be nice because highlyAvailable prefix by itself does not give enough information. Line 33: private Boolean highlyAvailableIsActive; Line 34: private Boolean highlyAvailableGlobalMaintenance; Line 35: private Boolean highlyAvailableLocalMaintenance; Line 36: -- To view, visit http://gerrit.ovirt.org/23530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib62849ffe0f7392c1feb1f2a0536a23410b58210 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
