Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier: Support snmp trap as a notification method. ......................................................................
Patch Set 35: (1 comment) http://gerrit.ovirt.org/#/c/22909/35/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java: Line 142: notifyObservers(DispatchResult.failure(event, address, EventNotificationMethod.SNMP_TRAP, e.getMessage())); Line 143: } Line 144: } Line 145: } Line 146: > I would prefer to see getters and setters used here. these are private data only structures, not exposed to anyone. Similar to DispatchAttempt. Line 147: private static class Host { Line 148: public String name; Line 149: public int port = 162; Line 150: -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 35 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
