Alon Bar-Lev has posted comments on this change. Change subject: tools: notifier: move mail specific validations into smtp transport ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24520/2/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 132 Line 133 Line 134 Line 135 Line 136 > I think this needs to stay here? see the Smtp, it was moved there. the idea of having single monolithic object to check anything is wrong... I solved it nicely in future patches, by adding the active flag for transport. -- To view, visit http://gerrit.ovirt.org/24520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c956198a2bb41deff7259607feb83dfe1a7ad53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
