Liron Ar has posted comments on this change. Change subject: core: Rephrase CDA message when removing a last copy of a template disk ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24245/2/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 24: No operational Host in Data Center or Data Center state is not Up. Line 25: VM_TEMPLATE_IS_LOCKED=Template is currently locked (temporarily). Line 26: VM_TEMPLATE_IMAGE_IS_LOCKED=Template's Image is locked (temporarily). Line 27: VM_TEMPLATE_IMAGE_IS_ILLEGAL=Template's Image is invalid (temporarily). Line 28: VM_TEMPLATE_IMAGE_LAST_DOMAIN=Cannot ${action} ${type} as it is the only remaining image of a template disk. 1. the convention is generally : =Cannot ${action} ${type}. {relevant message} can we change this message to meet the convention? 2. /template/Template (that's the convention here) 3. /image/copy Line 29: VM_NAME_CANNOT_BE_EMPTY=VM Name cannot be empty. Line 30: VM_CANNOT_UPDATE_ILLEGAL_FIELD=There was an attempt to change VM values while the VM is not down. Please shut down the VM in order to modify these properties. Line 31: VM_CANNOT_UPDATE_DEVICE_VM_NOT_DOWN=Failed updating the properties of the VM. VM should be in status Down in order to change the ${device} device. Line 32: VM_CANNOT_RUN_FROM_NETWORK_WITHOUT_NETWORK=VM is configured to be 'Network bootable', but no Network Interface is configured.\n\ -- To view, visit http://gerrit.ovirt.org/24245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42e2fefb8ba95bd7e83de75d1d90ff5eef2cb102 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: A Burden <abur...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
