Roy Golan has posted comments on this change.

Change subject: core, engine, webadmin: Retrieve Capabilities for each 
Architecture
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/23238/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java:

Line 10: import org.ovirt.engine.core.compat.Version;
Line 11: 
Line 12: public class GetArchitectureCapabilitiesQuery<P extends 
ArchCapabilitiesParameters> extends QueriesCommandBase<P> {
Line 13: 
Line 14:     private static final Map<ArchCapabilitiesVerb, 
Map<ArchitectureType, Map<Version, Boolean>>> verbMap =
EnumMap suits these cases - 

 EnumMap<ArchCapabilitiesVerb<EnumMap<ArchitectureType,Pair<Version,boolean>>>

compact and strong typed, without the wasted space of the map factors
Line 15:             new HashMap<ArchCapabilitiesVerb, Map<ArchitectureType, 
Map<Version, Boolean>>>();
Line 16: 
Line 17:     public GetArchitectureCapabilitiesQuery(P parameters) {
Line 18:         super(parameters);


-- 
To view, visit http://gerrit.ovirt.org/23238
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied1a97f5bdd42382f0dc832a3fe3abd56d3c89dd
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa 
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to