Oved Ourfali has posted comments on this change. Change subject: webadmin, backend: control of hosted engine maintenance mode ......................................................................
Patch Set 3: Code-Review+1 (1 comment) see minor comment. Also - you should add a UI maintainer to review that as well. And Doron should also review, I guess. http://gerrit.ovirt.org/#/c/23531/3/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 207: VDC_START=Starting oVirt Engine. Line 208: VDC_STOP=Stopping oVirt Engine. Line 209: VDS_ACTIVATE=Host ${VdsName} was activated by ${UserName}. Line 210: VDS_ACTIVATE_ASYNC=Host ${VdsName} was autorecovered. Line 211: VDS_ACTIVATE_MANUAL_HA=Host ${VdsName} was activated by ${UserName}, but Hosted Engine HA may still be in maintenance mode. If necessary, please correct this manually. Looks a bit confusing to me. Perhaps write "but the Hosted Engine HA service", to give some clue as for what is the hosted engine HA? Doron - thoughts? Line 212: VDS_ACTIVATE_MANUAL_HA_ASYNC=Host ${VdsName} was autorecovered, but Hosted Engine HA may still be in maintenance mode. If necessary, please correct this manually. Line 213: VDS_ACTIVATE_FAILED=Failed to activate Host ${VdsName}.(User: ${UserName}). Line 214: VDS_ACTIVATE_FAILED_ASYNC=Failed to autorecover Host ${VdsName}. Line 215: HOST_REFRESHED_CAPABILITIES=Successfully refreshed the capabilities of host ${VdsName}. -- To view, visit http://gerrit.ovirt.org/23531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f76f7ad63bcf6d7871c362b46cfa6e928eb9c74 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
