Alon Bar-Lev has posted comments on this change. Change subject: tools: extract MAIL_RETRIES to configuration ......................................................................
Patch Set 1: this kind of patch should be moved into before the "simple first match..." patch. the way we work if it was not clear because of the noise... is in reverse. I know how I want to see the snmp patch, and I know how the filters should look like, any violation means that there is something in the design that is incorrect, so we fix it before these patches recursively to allow these two patches to be pure which means that at least we contributed something positive to the software during the addition of a new feature. I am also fine in squashing this into "implement... idle" as you touch these anyway there. -- To view, visit http://gerrit.ovirt.org/24498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72d4f48c44d0dff70963394b2657a833449812bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
