Alon Bar-Lev has uploaded a new change for review.

Change subject: packaging: setup: remove: first remove files, then content
......................................................................

packaging: setup: remove: first remove files, then content

remove is stronger than content.

Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1058018
Change-Id: Ibc4cc0c126dcc214ebaddd1bbdb2e86b7db4f5a8
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/69/24469/1

diff --git 
a/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py 
b/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py
index 7065327..e7ef095 100644
--- a/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py
+++ b/packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/files/simple.py
@@ -287,10 +287,6 @@
         priority=plugin.Stages.PRIORITY_LOW,
     )
     def _misc(self):
-        self.logger.info(_('Reverting changes to files'))
-        for f in self._tomodifylines:
-            if os.path.exists(f):
-                self._revertChanges(f, self._lines[f])
         self.logger.info(_('Removing files'))
         for f in self._toremove:
             if os.path.exists(f):
@@ -309,6 +305,11 @@
                 # dead link
                 self._safeDelete(f)
 
+        self.logger.info(_('Reverting changes to files'))
+        for f in self._tomodifylines:
+            if os.path.exists(f):
+                self._revertChanges(f, self._lines[f])
+
         for info in self._infos:
             self._safeDelete(info)
 


-- 
To view, visit http://gerrit.ovirt.org/24469
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc4cc0c126dcc214ebaddd1bbdb2e86b7db4f5a8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to