Allon Mureinik has posted comments on this change. Change subject: core: Add a validation when deactivate ISO domain. ......................................................................
Patch Set 17: Code-Review+2 (2 comments) Please fix the tests and the apperror before merging. http://gerrit.ovirt.org/#/c/20331/17/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java: Line 79: Line 80: StorageDomainPoolParametersBase params = new StorageDomainPoolParametersBase(Guid.newGuid(), Guid.newGuid()); Line 81: DeactivateStorageDomainCommand<StorageDomainPoolParametersBase> cmd = Line 82: spy(new DeactivateStorageDomainCommand<StorageDomainPoolParametersBase>(params)); Line 83: change to public, add @Before, and remove the call from all the tests. Line 84: private void setup() { Line 85: doReturn(dbFacade).when(cmd).getDbFacade(); Line 86: when(dbFacade.getStoragePoolDao()).thenReturn(storagePoolDAO); Line 87: when(dbFacade.getStorageDomainDao()).thenReturn(storageDomainDAO); http://gerrit.ovirt.org/#/c/20331/17/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 817: TAGS_CANNOT_REMOVE_TAG_NOT_EXIST=Cannot remove tag. Tag does not exist. Line 818: VAR__TYPE__VM__CLUSTER=$type VM Cluster Line 819: VDS_FENCE_OPERATION_FAILED=Cannot ${action} ${type}. Fence operation failed. Line 820: VM_CANNOT_WITHOUT_ACTIVE_STORAGE_DOMAIN_ISO=Cannot ${action} without active ISO domain. Line 821: ERROR_CANNOT_DEACTIVATE_STORAGE_DOMAIN_WITH_ISO_ATTACHED=Cannot ${action} ${type}. The ISO Storage Domain is being used by the following VMs: ${VmNames}. Can we have the domain's name here please? Line 822: MAC_ADDRESS_IS_IN_USE=MAC Address is in use. Line 823: CAN_DO_ACTION_GENERAL_FAILURE=General command validation failure. Line 824: ERROR_CANNOT_REMOVE_ACTIVE_STORAGE_POOL=Cannot remove an active Data Center. Line 825: ROLE_TYPE_CANNOT_BE_EMPTY=Invalid Role Type. -- To view, visit http://gerrit.ovirt.org/20331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47c1a8155762ecd0b04bb17676151946982bb919 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
