Liron Ar has posted comments on this change. Change subject: engine: Only iSCSI storage connections are viable for iSCSI Bond ......................................................................
Patch Set 3: (1 comment) reviewed stored procedure - better approach IMO would be to use the current GetAllConnectableStorageSeverConnection and add a type as a parameter to it, if it's null - return all to not break the current API, otherwise return only the connections of that type. yeah, we would make union that way, but that's a non issue..much easier to maintain and it's not so commonly used anyway - should be just fine. http://gerrit.ovirt.org/#/c/23720/3/packaging/dbscripts/storages_san_sp.sql File packaging/dbscripts/storages_san_sp.sql: Line 550: END; $procedure$ Line 551: LANGUAGE plpgsql; Line 552: Line 553: Line 554: Create or replace FUNCTION GetConnectableBlockStorageConnectionsByType(v_storage_pool_id UUID, v_storage_type integer) better approach IMO would be to use the current GetAllConnectableStorageSeverConnection and add a type as a parameter to it, if it's null - return all to not break the current API, otherwise return only the connections of that type. yeah, we would make union that way, but that's a non issue..much easier to maintain and it's not so commonly used anyway - should be just fine. Line 555: RETURNS SETOF storage_server_connections STABLE Line 556: AS $procedure$ Line 557: BEGIN Line 558: RETURN QUERY SELECT distinct connection.* -- To view, visit http://gerrit.ovirt.org/23720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae30db6aa0c5d2989e9e31566d6555d70259799e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
