Allon Mureinik has uploaded a new change for review.
Change subject: webadmin: RunOnceModel empty string validation
......................................................................
webadmin: RunOnceModel empty string validation
Replaced the test for domain's emptiness from
StringHelper.stringsEquals(selectedDomain, "") to a simpler
StringHelper.isNullOrEmpty(selectedDomain). Note that although there is
a slight difference in semantics, there is no point in having a null
selectedDomain, and it's implicitly assumed to be not-null in other
places of the code.
Change-Id: I101f3d24a1bf7dd74b73931258e4dee101931618
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/37/24437/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
index f17d491..ae85ed4 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
@@ -890,7 +890,7 @@
}
getSysPrepDomainName().setItems(domains);
String selectedDomain = (oldDomain != null) ?
oldDomain : Linq.firstOrDefault(domains);
- if (!StringHelper.stringsEqual(selectedDomain, "")) {
//$NON-NLS-1$
+ if (!StringHelper.isNullOrEmpty(selectedDomain)) {
getSysPrepDomainName().setSelectedItem(selectedDomain);
}
}
--
To view, visit http://gerrit.ovirt.org/24437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I101f3d24a1bf7dd74b73931258e4dee101931618
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
