Alon Bar-Lev has posted comments on this change. Change subject: tools: Fix hostname validation in notifier ......................................................................
Patch Set 1: Please move it up heal, it should be before the simple first match include/exclude. I do not understand why everything becomes that complex... I really don't, can you please provide an example of these checks in other sane services? Up to now I never saw these... user specify name, we use, this way there is no problem of using ipv4, ipv6, dns and any other name that is provided by system nss. I suggest to drop the verification entirely saving 158 lines of code. -- To view, visit http://gerrit.ovirt.org/24426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9f269ef71d7f3b73ac930afd01af6699ca26f9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
