Martin Peřina has posted comments on this change. Change subject: tools: Adds more argument validations to engine-manage-domains ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24353/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java: Line 201: .build()); Line 202: Line 203: parser.addArg(new ArgumentBuilder() Line 204: .longName(ARG_PASSWORD_FILE) Line 205: .valueRequied(true) > I guess I missed that in previous reviews... There's no need to specify --ldap-servers without value. If --ldap-servers arg is not specified, DNS is search for LDAP servers. If --ldap-servers arg is specified, then its values is used as LDAP servers Line 206: .build()); Line 207: Line 208: parser.addArg(new ArgumentBuilder() Line 209: .longName(ARG_CHANGE_PASSWORD_MSG) -- To view, visit http://gerrit.ovirt.org/24353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7684387b62ce8eeda0416e4d2b3cfb2337cd7f16 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
