Liron Ar has posted comments on this change. Change subject: core: Make sure disk alias will never be null ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24269/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java: Line 143: return diskAlias; Line 144: } Line 145: Line 146: public void setDiskAlias(String diskAlias) { Line 147: this.diskAlias = diskAlias == null ? "" : diskAlias; this verifies that only if we call setDiskAlias, if we didn't call it - diskAlias could still be null. we should possibly have a default value for the disk alias, and we shall override it only when needed (not empty or null) Line 148: } Line 149: Line 150: public boolean isShareable() { Line 151: return shareable; -- To view, visit http://gerrit.ovirt.org/24269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I110f40b121a0bff8117888399fd5b798a9f19c10 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
