Mike Kolesnik has uploaded a new change for review. Change subject: engine: Use collection for object names ......................................................................
engine: Use collection for object names For nameable objects, there's no need to use a list for creating a set of the object names, just use any collection. Change-Id: I9451323cf5b9a3edd5f538ada69d8427a7bd4145 Related-To: https://bugzilla.redhat.com/1055161 Signed-off-by: Mike Kolesnik <mkole...@redhat.com> (cherry picked from commit 2f4f23da31d386223d05f603f91b2d815b5cde7f) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/24355/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java index e636023..2757432 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java @@ -75,10 +75,10 @@ } } - public static <E extends Nameable> Set<String> objectNames(List<E> entityList) { - if (entityList != null && !entityList.isEmpty()) { + public static <E extends Nameable> Set<String> objectNames(Collection<E> entities) { + if (entities != null && !entities.isEmpty()) { Set<String> names = new HashSet<String>(); - for (E e : entityList) { + for (E e : entities) { names.add(e.getName()); } return names; -- To view, visit http://gerrit.ovirt.org/24355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9451323cf5b9a3edd5f538ada69d8427a7bd4145 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
