Doron Fediuck has posted comments on this change. Change subject: ovirt-engine: fixing installCA_dev to work without ovirt-engine rpms ......................................................................
Patch Set 1: (5 inline comments) .................................................... File backend/manager/conf/ca/installCA_dev.sh Line 38: ENGINE_DEPLOY_DIR="/usr/share/ovirt-engine" Shouldn't this be $3? JBOSS_HOME??? wither way it shouldn;t be hard-coded. Line 41: mkdir -p $ENGINE_DEPLOY_DIR Please replace the tab with spaces. Line 46: I think it will be wise to very the link was create. either use ln xxx | | die YYY or [ ! -d xxx] Line 86: #cleanup cleanup should go before printing. Line 88: unlink "$ENGINE_DEPLOY_DIR/engine.ear" and make sure to: 1. remove tab 2. check if unlink worked. If not, it may fail you on next run. -- To view, visit http://gerrit.ovirt.org/4393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I103352dbd6bab68d783c61a87fafeabce8776a77 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
