Arik Hadas has posted comments on this change. Change subject: core, restapi: move destinationVdsId from to RunVmOnceParams ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24256/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java: Line 267: RunVmOnceParams params = map(vm, map(map(getEntity(entityType, VdcQueryType.GetVmByVmId, new IdQueryParameters(guid), id, true), new VM()), Line 268: new RunVmOnceParams(guid))); Line 269: if (vm.isSetPlacementPolicy() && vm.getPlacementPolicy().isSetHost()) { Line 270: validateParameters(vm.getPlacementPolicy(), "host.id|name"); Line 271: params.setDestinationVdsId(getHostId(vm.getPlacementPolicy().getHost())); This change is needed because we need the params to be of type RunVmOnceParams in order to invoke the setDestinationVdsId method Line 272: } Line 273: if (vm.isSetInitialization() && vm.getInitialization().isSetCloudInit()) { Line 274: CloudInit cloudInit = vm.getInitialization().getCloudInit(); Line 275: // currently only 'root' user is supported, alert the user if other user sent -- To view, visit http://gerrit.ovirt.org/24256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6bb75da2c2030f71da26c8690a6931319f6904f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
