Michael Pasternak has posted comments on this change.
Change subject: restapi: Support max result num for queries
......................................................................
Patch Set 2: (4 inline comments)
please remove whitespaces in yaml
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 1347: max: {context: matrix, type: 'xs:int', value: 'max results',
required: false}
not valid here as this is not query
Line 1665: max: {context: matrix, type: 'xs:int', value: 'max results',
required: false}
not valid here as this is not query
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
Line 105: HashMap<String,String> matrixConstraints =
QueryHelper.getMatrixConstraints(getUriInfo(), MAX);
i'd put: getUriInfo()!=null && QueryHelper.hasMatrixParam(getUriInfo(), MAX)
condition here.
Line 107: int max = Integer.valueOf(maxString);
any disaster recovery from not-number?
--
To view, visit http://gerrit.ovirt.org/2902
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc545e7084d6e34aca5c62a448575daf68960fd9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
