Moti Asayag has posted comments on this change. Change subject: core:remove single unknown tasks from the task(817817) ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/dbscripts/job_sp.sql Line 99: WHERE correlation_id = v_correlation_id and status != 'UNKNOWN'; i agree with Yair's comment on the bug - we shouldn't filter out any data when a group of specific jobs is queries. a possible outcome (with this change) the entire actions failed, but we don't get the job which actually caused the failure. Line 358: ---------------------------------------------------- The step will have UNKNOWN status only if the Job is UNKNOWN, therefore we don't need to specify it on step level. Line 392: FROM step same as above. -- To view, visit http://gerrit.ovirt.org/4428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23d0b2dd1f2d07393c49e705a657cd97c9106c7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
