Daniel Erez has posted comments on this change. Change subject: engine: Add action type for snapshot. ......................................................................
Patch Set 14: (3 comments) http://gerrit.ovirt.org/#/c/20420/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java: Line 269: imagesToRestore = getParameters().getImages(); Line 270: restoreConfiguration(targetSnapshot); Line 271: break; Line 272: Line 273: // Currently UI sends the "in preview" snapshot to restore when "Commit" is pressed. the comment can be removed now Line 274: case REGULAR: Line 275: prepareToDeletePreviewBranch(); Line 276: Line 277: // Set the active snapshot's images as target images for restore, because they are what we keep. http://gerrit.ovirt.org/#/c/20420/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java: Line 366: { Line 367: VM vm = (VM) getEntity(); Line 368: if (vm != null) Line 369: { Line 370: Snapshot snapshot = getPreview(); can be removed now Line 371: Line 372: Frontend.getInstance().runAction(VdcActionType.RestoreAllSnapshots, Line 373: new RestoreAllSnapshotsParameters(vm.getId(), SnapshotAction.UNDO), Line 374: null, Line 380: { Line 381: VM vm = (VM) getEntity(); Line 382: if (vm != null) Line 383: { Line 384: Snapshot snapshot = getInPreview(); can be removed now Line 385: Line 386: Frontend.getInstance().runAction(VdcActionType.RestoreAllSnapshots, Line 387: new RestoreAllSnapshotsParameters(vm.getId(), SnapshotAction.COMMIT), Line 388: null, -- To view, visit http://gerrit.ovirt.org/20420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If877befc5058c3412ae3d3731d5beacbc09e5c97 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
