Omer Frenkel has submitted this change and it was merged. Change subject: core: refactor failure to run vm flow - part 2 ......................................................................
core: refactor failure to run vm flow - part 2 When migration fails and the VM get back to UP state in the source host, we do not want to treat the VM as VM that failed to run. Thus, MigrateVmCommand overrides RunVmCommandBase#failedToRunVm method and do not do anything in that case. Instead of override the whole RunVmCommandBase#failedToRunVm method, it is better to override just the RunVmCommandBase#processVmPoolOnStopVm method so the rest of the things that failedToRunVm do would be executed. In addition, the code in RunVmCommandBase#reportCompleted was simplified a bit. Change-Id: I6dc8e13f1ab932283557b3cbf16a34e72b9b3a69 Signed-off-by: Arik Hadas <aha...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 2 files changed, 13 insertions(+), 11 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/23643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6dc8e13f1ab932283557b3cbf16a34e72b9b3a69 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
