Michael Kublin has posted comments on this change.
Change subject: core: Use allow snapshot when filter images.
......................................................................
Patch Set 9: (1 inline comment)
Look ok , but please remove passing of diskStorageType to ImagesHandler, u
don't need it, when done +2
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 596: DiskStorageType diskStorageType) {
you don't need diskStorageType here, it is usually DiskImage , it is means
ImageDisk
--
To view, visit http://gerrit.ovirt.org/4312
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib34a90fdf7c53d80ce52aec98b7c810ece2c6ad3
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
