Mike Kolesnik has posted comments on this change. Change subject: engine: Do not invoke CommitNetworkChanges if not needed ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24123/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java: Line 37: public class SetupNetworksCommand<T extends SetupNetworksParameters> extends VdsCommand<T> { Line 38: Line 39: public static enum SETUP_NETWORKS_RESOLUTION { Line 40: NO_CHANGES_DETECTED; Line 41: }; Please add newline here Line 42: /** Time between polling attempts, to prevent flooding the host/network. */ Line 43: private static final long POLLING_BREAK = 500; Line 44: private static final List<VDSStatus> SUPPORTED_HOST_STATUSES = Line 45: Arrays.asList(VDSStatus.Maintenance, VDSStatus.Up, VDSStatus.NonOperational); -- To view, visit http://gerrit.ovirt.org/24123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06d43ffaf899af4749bb1221764d40fab10a572 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
