Michael Pasternak has posted comments on this change. Change subject: cli: Using true as a default for boolean flags(#1006918) ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/20804/3/src/ovirtcli/command/command.py File src/ovirtcli/command/command.py: Line 194: def fixParamNameIfParamIsKeyword(self, param): Line 195: if param in dir(__builtin__) or keyword.iskeyword(param): Line 196: return param + '_' Line 197: return param Line 198: > I have no way of determining the type as bool for the attribute prop. So if please see two possible solutions [1] for addressing this issue. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1006918#c7 thanks Line 199: def __set_property(self, obj, prop, val, fq_prop): Line 200: """INTERNAL: set data in to property""" Line 201: if val == None: Line 202: if hasattr(obj, prop): -- To view, visit http://gerrit.ovirt.org/20804 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie87885a1219b20967241bde4e91b363355a5ea51 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
