Alexander Wels has posted comments on this change.

Change subject: userportal,webadmin: synchronize grid refresh
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/23605/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java:

Line 35:         void onManualRefresh();
Line 36: 
Line 37:     }
Line 38: 
Line 39:     // Prefix for keys used to store refresh rates of individual data 
grids
> I suggest to update comment as well, for example:
Done
Line 40:     private static final String GRID_REFRESH_RATE_KEY = 
"GridRefreshRate"; //$NON-NLS-1$
Line 41: 
Line 42:     private static final Integer DEFAULT_REFRESH_RATE = 
GridTimer.DEFAULT_NORMAL_RATE;
Line 43:     private static final Integer OUT_OF_FOCUS_REFRESH_RATE = 
Integer.valueOf(60000);


-- 
To view, visit http://gerrit.ovirt.org/23605
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8742785cb9b3d890c39859586b03cd53c64b31e5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to