Eli Mesika has posted comments on this change.

Change subject: core : No email notification sent when host recovers from 
previously reported condition
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/23399/4/packaging/dbscripts/upgrade/03_04_0610_map_vds_detected_to_event_map.sql
File packaging/dbscripts/upgrade/03_04_0610_map_vds_detected_to_event_map.sql:

Line 1: update event_map set event_down_name = 'VDS_DETECTED' where 
event_up_name='VDS_SET_NONOPERATIONAL';
Line 2: update event_map set event_down_name = 'VDS_DETECTED' where 
event_up_name='VDS_SET_NONOPERATIONAL_IFACE_DOWN';
Line 3: update event_map set event_down_name = 'VDS_DETECTED' where 
event_up_name='VDS_SET_NONOPERATIONAL_DOMAIN';
IMHO , should be values should be switched 

event_down == problem
event_up == problem resolved


-- 
To view, visit http://gerrit.ovirt.org/23399
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93038f1ef81aa82643eb1b0e4bf9bc523a28b22c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to