Alon Bar-Lev has posted comments on this change. Change subject: doc: branding: style cleanups ......................................................................
Patch Set 2: (2 comments) thanks! two style comments and merge... http://gerrit.ovirt.org/#/c/24141/2/README.branding File README.branding: Line 179: obrand.userportal.my_new_message=BrandX Message Line 180: You'll need to add one for both webadmin and userportal if you want Line 181: the message exposed to both applications. If you want the same message Line 182: in both user portal and webadmin you can use obrand.common.my_new_message Line 183: and it will be available in both. If you want to use the same key but remove space Line 184: have different message you can use the above. Line 185: NOTE: Use messages.properties for any messages that will need to be Line 186: translated into other languages. Use external_messages.properties for Line 187: anything else, like URLs. Line 198: copy of ApplicationConstants.java. Line 199: 5a. If the message will be exposed to webadmin, add an addFallback() call in Line 200: webadmin's copy of ApplicationDynamicMessages.java. Use existing calls as Line 201: examples. Line 202: 5b. If the message will be exposed to userportal, repeat 5a for userportal's copy wrap copy Line 203: of ApplicationDynamicMessages.java. Line 204: Line 205: You can now use an injected ApplicationDynamicMessages to access the branded Line 206: messages. -- To view, visit http://gerrit.ovirt.org/24141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I339f60c54aa6e54ff78d82e525b00dff8ba36026 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
