Maor Lipchuk has posted comments on this change. Change subject: core: disk live migrate - snapshot only on migrated disks ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24075/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 364: Line 365: private SnapshotVDSCommandParameters buildLiveSnapshotParameters(Snapshot snapshot) { Line 366: List<Disk> pluggedDisksForVm = getDiskDao().getAllForVm(getVm().getId(), true); Line 367: List<DiskImage> filteredPluggedDisksForVm = ImagesHandler.filterImageDisks(pluggedDisksForVm, false, true, true); Line 368: List<DiskImage> filteredPluggedDisks = ImagesHandler.imagesIntersection(filteredPluggedDisksForVm, getDisksList()); Please consider to add a comment, or extract it to other method Line 369: Line 370: if (FeatureSupported.memorySnapshot(getVm().getVdsGroupCompatibilityVersion())) { Line 371: return new SnapshotVDSCommandParameters(getVm().getRunOnVds(), Line 372: getVm().getId(), -- To view, visit http://gerrit.ovirt.org/24075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21387ef38b5f86806b985b8dffb49d5b7952a628 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
