Michael Pasternak has posted comments on this change. Change subject: cli: Check that the --max option has a value ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24080/2/src/ovirtcli/command/command.py File src/ovirtcli/command/command.py: Line 261: Line 262: # Check that all the options that require a value actually have it: Line 263: for k, v in mopts.iteritems(): Line 264: if v is None and self._is_value_required(k): Line 265: self.error(Messages.Error.OPTION_REQUIRES_VALUE % k) > > This is not the case for the "max" option, it works the same for all "lis BTW, i can give you one real life example right now, you have open RFE in CLI to allow boolean based options to behave like a flag, i.e if one pass --boot (probably will have to add extra header cause it won't be the default), for server it means boot=True, keeping CLI generic (option content agmostic), will cost nothing to implement this feature, while using per-case validations like you did [1], implementing this feature won't scale. [1] i know that you did for --max only, but i think we should keep code consistent, J., does this make sense? Line 266: Line 267: return query, kw Line 268: Line 269: -- To view, visit http://gerrit.ovirt.org/24080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0801c60d33b5e30f8844659df98e6d8405f34167 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
