Ravi Nori has posted comments on this change. Change subject: core:OnVdsDuringFailureTimer log message malformed ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23824/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 498: && vds.getStatus() == VDSStatus.Error) { Line 499: setStatus(VDSStatus.Up, vds); Line 500: DbFacade.getInstance().getVdsDynamicDao().updateStatus(getVdsId(), VDSStatus.Up); Line 501: } Line 502: log.infoFormat("onVdsDuringFailureTimer of Host {0} entered after {1} attempts to run a VM", vds.getName(), Just a suggestion, will the following be a better message Host {0} entered onVdsDuringFailureTimer after {1} attempts to run a VM. Line 503: mFailedToRunVmAttempts); Line 504: } Line 505: } Line 506: -- To view, visit http://gerrit.ovirt.org/23824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaf1d7c351a2d63d7f3cc58609a9c5016b8a13f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
