Eli Mesika has posted comments on this change. Change subject: fixing integer out of range exception in search ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/23488/6/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java: Line 959: case Range: Line 960: result = Line 961: StringFormat.format(pagingSyntax, Line 962: BigInteger.valueOf((page - 1) * syntax.getMaxCount() + 1), Line 963: BigInteger.valueOf(page * syntax.getMaxCount())); > This doesn't take advantage of the BigInteger, as the calculation is done w Done Line 964: break; Line 965: case Offset: Line 966: result = StringFormat.format(pagingSyntax, BigInteger.valueOf((page - 1) * syntax.getMaxCount() + 1), syntax.getMaxCount()); Line 967: break; Line 962: BigInteger.valueOf((page - 1) * syntax.getMaxCount() + 1), Line 963: BigInteger.valueOf(page * syntax.getMaxCount())); Line 964: break; Line 965: case Offset: Line 966: result = StringFormat.format(pagingSyntax, BigInteger.valueOf((page - 1) * syntax.getMaxCount() + 1), syntax.getMaxCount()); > Same here. Done Line 967: break; Line 968: } Line 969: } Line 970: -- To view, visit http://gerrit.ovirt.org/23488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I518dfdfff93dde28d9741d5e333c695239b7e7d2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
