Juan Hernandez has posted comments on this change. Change subject: gluster:Datatype change for bytesRead & bytesWritten from int to long. ......................................................................
Patch Set 1: The correct way to handle these potentially large values is to the "statistics" mechanism, which supports large values and units. It is already used by gluster volumes, for example. As the "bytes_written" and "bytes_read" have been defined as optional, I would suggest to stop populating them, without removing them from the XML schema. This won't break compilation of SDK clients, the methods will just return null. In the future (4.0) we can remove them completely. However, I may be overcomplicating things, maybe no one is actually using this with the Java SDK. Why where these elements introduced? Where they requested by users? Do we know if those users are using the Java SDK? -- To view, visit http://gerrit.ovirt.org/23932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dd8f372059a4d0616bef34325e23d88a959bcba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
