Maor Lipchuk has posted comments on this change. Change subject: engine: Add action type for previewed snapshot. ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/20420/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreAllSnapshotsParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreAllSnapshotsParameters.java: Line 6: import org.ovirt.engine.core.common.businessentities.Snapshot.SnapshotAction; Line 7: import org.ovirt.engine.core.compat.Guid; Line 8: Line 9: public class RestoreAllSnapshotsParameters extends VmOperationParameterBase implements java.io.Serializable { Line 10: private static final long serialVersionUID = -8756081739745132849L; > if??? which if? I got confused without punctuation marks :) regarding the serialVersionUID, all the parameters file use them, IINM I think this is being serialized to the client, and we do need it. but I don't think that this is relevant to this patch scope Line 11: Line 12: private List<DiskImage> images; Line 13: private SnapshotAction snapshotAction; Line 14: -- To view, visit http://gerrit.ovirt.org/20420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If877befc5058c3412ae3d3731d5beacbc09e5c97 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
