Roy Golan has posted comments on this change.
Change subject: REST: translate VdcFault in case the error messages are empty
......................................................................
Patch Set 2: (1 inline comment)
The whole error reporting is not good enough, from VDSM through backend and up
to the clients.
What's the point reporting a key such as ERR_BAD_NIC when the localization
can't tell which nic is that?
I will abandon this patch because it was targeted as a a mid-solution till an
holistic one will come. I will find the resources and will send patches for
VDSM-backend-REST so and error like BAD_NIC could be populated with
interpolated values so localization can do stuff like:
ERR_BAD_NIC=Network Interface {0} does not exist
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
Line 146: throw new
BackendFailureException(localize(Arrays.asList(result.getFault().getError().name())));
I am passing a key not a message. why wont you use it to localise?
the key is a backend representation of the VDSM error, which is much like any
other BLL error
--
To view, visit http://gerrit.ovirt.org/2054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c3bd87ced4d44f5f656a0f24c9928ace43cb39b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
