Daniel Erez has uploaded a new change for review. Change subject: webadmin: clone vm from snapshot - validate disk sd ......................................................................
webadmin: clone vm from snapshot - validate disk sd Clone VM from Snapshot: verify that a target storage domain is selected for each disk. Change-Id: I1f5148295b46ce4394c407881217d34d3f7443a8 Related-To-Bug-Url: https://bugzilla.redhat.com/975114 Signed-off-by: Daniel Erez <de...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/24073/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java index fa7a411..798af1a 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java @@ -263,7 +263,8 @@ } for (DiskModel diskModel : getDisks()) { - if (!diskModel.getStorageDomain().getItems().iterator().hasNext()) { + ListModel diskStorageDomains = diskModel.getStorageDomain(); + if (!diskStorageDomains.getItems().iterator().hasNext() || diskStorageDomains.getSelectedItem() == null) { diskModel.getStorageDomain().getInvalidityReasons().add( constants.storageDomainMustBeSpecifiedInvalidReason()); diskModel.getStorageDomain().setIsValid(false); -- To view, visit http://gerrit.ovirt.org/24073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1f5148295b46ce4394c407881217d34d3f7443a8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
