Daniel Erez has uploaded a new change for review. Change subject: core: storage active validation on AddVmFromSnapshot ......................................................................
core: storage active validation on AddVmFromSnapshot Added validation for source storage domains on AddVmFromSnapshotCommand (i.e. source storage domains should be active). Change-Id: I44ab14a527d2af7dce1b11b8d96f7e384c7b2027 Bug-Url: https://bugzilla.redhat.com/975114 Signed-off-by: Daniel Erez <de...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/24072/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java index bd9b863..f40f7dc 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java @@ -5,6 +5,7 @@ import java.util.Collections; import java.util.List; import java.util.Map; +import java.util.Set; import org.apache.commons.lang.StringUtils; import org.ovirt.engine.core.bll.network.vm.VnicProfileHelper; @@ -12,6 +13,7 @@ import org.ovirt.engine.core.bll.utils.PermissionSubject; import org.ovirt.engine.core.bll.utils.VmDeviceUtils; import org.ovirt.engine.core.bll.validator.DiskImagesValidator; +import org.ovirt.engine.core.bll.validator.MultipleStorageDomainsValidator; import org.ovirt.engine.core.bll.validator.VmValidator; import org.ovirt.engine.core.common.AuditLogType; import org.ovirt.engine.core.common.VdcObjectType; @@ -329,6 +331,13 @@ return false; } + Set<Guid> storageIds = ImagesHandler.getAllStorageIdsForImageIds(disksToCheck); + MultipleStorageDomainsValidator storageValidator = + new MultipleStorageDomainsValidator(getStoragePoolId(), storageIds); + if (!validate(storageValidator.allDomainsExistAndActive())) { + return false; + } + if (!validate(new VmValidator(getSourceVmFromDb()).vmNotLocked())) { return false; } -- To view, visit http://gerrit.ovirt.org/24072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44ab14a527d2af7dce1b11b8d96f7e384c7b2027 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
