Tal Nisan has posted comments on this change. Change subject: webadmin: Add confirmation window when deactivating a VM disk ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24024/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java: Line 485: model.setMessage(ConstantsManager.getInstance().getConstants().areYouSureYouWantDeactivateVMDisksMsg()); Line 486: model.setHashName("deactivate_vm_disk"); //$NON-NLS-1$ Line 487: setWindow(model); Line 488: Line 489: model.getLatch().setEntity(false); This is not needed, please remove Line 490: Line 491: ArrayList<String> items = new ArrayList<String>(); Line 492: for (Object selected : getSelectedItems()) { Line 493: items.add(((Disk) selected).getDiskAlias()); -- To view, visit http://gerrit.ovirt.org/24024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13d9aa5386efd676d7b9d043c72c921ac3f07bf6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
