Mike Kolesnik has posted comments on this change. Change subject: core:Boot from CD doesn't work on 3.1 compatibility(820127) ......................................................................
Patch Set 1: (3 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java Line 61: (vm.isRunOnce() && vm.getboot_sequence() != vm.getdefault_boot_sequence()) ? vm.getboot_sequence() I think it's redundant to check: vm.getboot_sequence() != vm.getdefault_boot_sequence() Since if they are the same, then it doesn't matter which one you return, and if they differ you would return the vm.getboot_sequence() anyway. Only thing that makes a difference is checking vm.isRunOnce() .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java Line 480 Why remove this? Line 498: (vmDevice.getSpecParams() == null) ? new HashMap<String, Object>() : vmDevice.getSpecParams(); It might be better to use Collections.emptyMap() instead of new HashMap() -- To view, visit http://gerrit.ovirt.org/4378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida06b34f94e791a344e017cd5a6915e31b827cc9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
