Liran Zelkha has posted comments on this change. Change subject: core: Fix templates search query ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23811/2/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java: Line 908: syntax.getSearchFrom(), innerQuery); Line 909: } Line 910: } else if (primeryKey.equals("vmt_guid") && wherePhrase.length() == 0) { Line 911: inQuery = StringFormat Line 912: .format("(SELECT * FROM %1$s ", > I do not understand here how the missing closing ')' will get in ... See the database (vdc_options): 249 | PostgresSearchTemplate | SELECT * FROM (%2$s) %1$s) as T1 %3$s | general Horrifying, I know, but can't be fixed in this patch... Line 913: tableNameWithOutTags); Line 914: } else if (primeryKey.equals("vmt_guid") && wherePhrase.length() > 0 Line 915: && wherePhrase.toString().contains("storage_pool_name") && whereBuilder.size() == 1) { Line 916: inQuery = StringFormat -- To view, visit http://gerrit.ovirt.org/23811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ef77348bc6126f5b038e40d949de6d5804def5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
