Eli Mesika has posted comments on this change. Change subject: core: Improve audit_log seach query ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23567/4/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java: Line 899: .format("SELECT * FROM %1$s WHERE ( %2$s > %3$s and not deleted", Line 900: tableNameWithOutTags, primeryKey, Line 901: syntax.getSearchFrom()); Line 902: } else if (whereBuilder.size() == 1 && wherePhrase.toString().contains("severity")) { Line 903: inQuery = innerQuery + " and (not deleted"; How comes that this has just an opening '(' , who puts the closing one ??? Even if that works , we should find something that in first sight will look as a working code Line 904: } else { Line 905: inQuery = StringFormat Line 906: .format("SELECT * FROM %1$s WHERE ( %2$s > %3$s and %2$s IN (%4$s) and not deleted", Line 907: tableNameWithOutTags, primeryKey, -- To view, visit http://gerrit.ovirt.org/23567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I396a90d63a10fc049a37e4792d3e558ff2a7fea3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
