Liran Zelkha has posted comments on this change. Change subject: core: Move ResourceManager to batch update VdsDynamic ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23851/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java: Line 188: Line 189: }; Line 190: } Line 191: Line 192: private MapSqlParameterSource createFullParametersMapperForSave(VdsDynamic vds) { > Not sure I understood why there is a difference here, and with the batch ma You're right. Someone added a parameter controlled_by_pm_policy just to the insert, and not to the update command. Update is done via a separate method. I'm not sure if to fix it... Line 193: MapSqlParameterSource parameterSource = createFullParametersMapper(vds); Line 194: parameterSource.addValue("controlled_by_pm_policy", vds.isPowerManagementControlledByPolicy()); Line 195: return parameterSource; Line 196: } -- To view, visit http://gerrit.ovirt.org/23851 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If857a328d591f87cf453f1620f134d5e0a137363 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
