Tomas Jelinek has posted comments on this change. Change subject: frontend: Prepare frontend for console unit tests ......................................................................
Patch Set 1: (1 comment) just a small comment, otherwise it seems fine http://gerrit.ovirt.org/#/c/23973/1/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ConstantsManager.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/ConstantsManager.java: Line 22: return constants; Line 23: } Line 24: Line 25: // for testing purposes Line 26: public static void setConstants(UIConstants testConstants) { don't call it testConstants, just constants Line 27: constants = testConstants; Line 28: } Line 29: Line 30: public UIMessages getMessages() { -- To view, visit http://gerrit.ovirt.org/23973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icde9131d9415ba500eb2a222dc4e7187bf82f868 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
