Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: support classless IN-ADDR.ARPA delegation ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/23818/1/packaging/setup/plugins/ovirt-engine-setup/base/network/hostname.py File packaging/setup/plugins/ovirt-engine-setup/base/network/hostname.py: Line 95: _DIG_REVLOOKUP_RE = re.compile( Line 96: flags=re.VERBOSE, Line 97: pattern=r""" Line 98: ^ Line 99: (?P<query>[\w/.-]+) I tend to believe that only this change is sufficient... not sure about the '/'. Line 100: \. Line 101: \s+ Line 102: \d+ Line 103: \s+ Line 102: \d+ Line 103: \s+ Line 104: IN Line 105: \s+ Line 106: (?P<type>(PTR|CNAME)) no need... Line 107: \s+ Line 108: (?P<answer>[\w/.-]+) Line 109: \. Line 110: $ Line 104: IN Line 105: \s+ Line 106: (?P<type>(PTR|CNAME)) Line 107: \s+ Line 108: (?P<answer>[\w/.-]+) why '/' was added? Line 109: \. Line 110: $ Line 111: """ Line 112: ) Line 196: query=query, Line 197: answer=answer, Line 198: ) Line 199: ) Line 200: names.add(answer) as far as I understand, modifying the above re, is sufficient, no need for this code. Line 201: return names Line 202: Line 203: def _validateFQDNresolvability(self, fqdn): Line 204: -- To view, visit http://gerrit.ovirt.org/23818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f65fbc27992ddae0b3d01e19d317a2abe39db7b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mark Kachi <love.ca...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Mark Kachi <love.ca...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
