Eli Mesika has posted comments on this change.

Change subject: 1. core, tools: Supporting change password Url presentation
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/23250/11/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
File 
backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java:

Line 643:         return result;
Line 644:     }
Line 645: 
Line 646:     public void editDomain(CLIParser parser) throws 
ManageDomainsResult {
Line 647:         System.out.println("editting domain");
Should this print remain in final code ?
Line 648:         String authMode;
Line 649:         String domainName = 
parser.getArg(Arguments.domain.toString()).toLowerCase();
Line 650:         authMode = getDomainAuthMode(domainName);
Line 651:         validateKdcServers(authMode, domainName);


-- 
To view, visit http://gerrit.ovirt.org/23250
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8eb0f858e26bdefffe526623d025fac47791711e
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to