Alon Bar-Lev has posted comments on this change. Change subject: tools: This change introduces the EventSubscribersProvider interface. ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/23154/8/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/sender/EventSender.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/sender/EventSender.java: Line 15: Line 16: public EventSenderResult send(AuditLogEvent auditLogEvent, AuditLogEventSubscriber AuditLogEventSubscriber); Line 17: Line 18: } Line 19: does not belong to this patch http://gerrit.ovirt.org/#/c/23154/8/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/subscribers/ConfigurationSubscribersProvider.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/subscribers/ConfigurationSubscribersProvider.java: Line 47: } Line 48: } Line 49: } Line 50: Line 51: private void addSNMPSubscriber(Collection<AuditLogEventSubscriber> subscribers) { this belongs to snmp patch Line 52: String snmpManagerServer = properties.getProperty(NotificationProperties.SNMP_MANAGER, true); Line 53: if (!StringUtils.isEmpty(snmpManagerServer)) { Line 54: AuditLogEventSubscriber snmpSubscriber = new AuditLogEventSubscriber(); Line 55: snmpSubscriber.setUsername(NotificationProperties.SNMP_MANAGER); -- To view, visit http://gerrit.ovirt.org/23154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id863557f3902ab18f5dac7a822ca55ad0c96dda5 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
