Allon Mureinik has posted comments on this change. Change subject: core: Block live storage migration to domain of a different type ......................................................................
Patch Set 3: Code-Review+2 (2 comments) @Itamar - currently, for block storage, we attempt to extend both src and dest, which will probably break. Let's take the safer approach first, and alleviate the restriction later if possible. http://gerrit.ovirt.org/#/c/23759/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-01-28 17:22:55 +0200 Line 4: Commit: Tal Nisan <tni...@redhat.com> Line 5: CommitDate: 2014-01-28 17:22:55 +0200 Line 6: Line 7: core: Block live storage migration to domain of a different type s/type/subtype/ ? Line 8: Line 9: This change fails live storage migration CDA part in case that the source Line 10: storage domain and the destination domain are not both either a file Line 11: type domain or a block domain http://gerrit.ovirt.org/#/c/23759/3/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java: Line 205: assertFalse(command.canDoAction()); Line 206: assertTrue(command.getReturnValue() Line 207: .getCanDoActionMessages() Line 208: .contains(VdcBllMessages.ACTION_TYPE_FAILED_DESTINATION_AND_SOURCE_STORAGE_SUB_TYPES_DIFFERENT.toString())); Line 209: } Please also add a test for other way (ISCSI to NFS) - this currently should fail, but we may want to enable this in the future. Line 210: Line 211: @Test Line 212: public void canDoActionVmRunningStateless() { Line 213: createParameters(); -- To view, visit http://gerrit.ovirt.org/23759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec4c34132a1a619527627cfa47fa99df3a023b62 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
