Michael Pasternak has posted comments on this change.
Change subject: restapi: non admin user api - exposing filtering param (#783087)
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
please add unit-test
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
Line 310: protected boolean isFiltered() {
1. no need to retrieve header on each isFiltered() call (can be few durring
the session), you can save it - it won't change.
2.we already have same code (you can reuse it), see SessionUtils
--
To view, visit http://gerrit.ovirt.org/4360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e5e23cbb8e883f6005f69be46fa528ac6e7518c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
