Sahina Bose has posted comments on this change. Change subject: gluster: fix cleaning up orphan tasks ......................................................................
Patch Set 1: (1 comment) Please take care of unit test too http://gerrit.ovirt.org/#/c/23936/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java: Line 334: Line 335: for (Guid taskId: tasksNotRunning) { Line 336: GlusterVolumeEntity vol= getVolumeDao().getVolumeByGlusterTask(taskId); Line 337: if (vol != null && vol.getStatus() != GlusterStatus.UP Line 338: || !runningTasksInClusterMap.keySet().contains((vol.getClusterId()))) { ((vol != null && vol.getStatus() != GlusterStatus.UP) || !runningTasksInClusterMap.keySet().contains((vol.getClusterId()) ? Line 339: // the volume is not UP. Hence gluster may not have been able to return tasks for the volume Line 340: // also handling the case where gluster was not able to return any tasks from this cluster - the keyset will not Line 341: // contain the cluster id in such case Line 342: continue; -- To view, visit http://gerrit.ovirt.org/23936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f9bb53e5c2be194efeba966355d0245bcc18384 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
