Lior Vernia has posted comments on this change. Change subject: webadmin: Fix action button regression fix ......................................................................
Patch Set 1: (1 comment) Added small comment. http://gerrit.ovirt.org/#/c/23920/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java: Line 101: // List of buttons that only show in the tool-bar. Line 102: private final List<ActionButtonDefinition<T>> toolbarOnlyActionButtonList = Line 103: new ArrayList<ActionButtonDefinition<T>>(); Line 104: // List of original visibility state for each button Line 105: private final Map<Widget, Boolean> originallyVisible = new HashMap<Widget, Boolean>(); Consider using a Set instead, and insert only buttons that were originally visible. Line 106: Line 107: private final SearchableModelProvider<T, ?> dataProvider; Line 108: private final EventBus eventBus; Line 109: -- To view, visit http://gerrit.ovirt.org/23920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3c5ccb0a8732b206c94591b930fc6a01456a47d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
